fix(gosearch): address plan review feedback

- Add note about vendorHash placeholder in gosearch flake
- Make search functionality test more explicit with jq verification
This commit is contained in:
ashisgreat22 2026-03-21 22:10:27 +00:00
parent e39c2a3c7a
commit 616079fc90

View file

@ -50,6 +50,8 @@ inputs = {
Run: `nix flake update --commit-lockfile`
Expected: Lockfile updates successfully, no errors
**Note:** The gosearch flake has a placeholder `vendorHash = ""` in its flake.nix. During the first `nixos-rebuild build`, Nix will fail with the correct hash. This is expected — you'll need to copy that hash into the gosearch flake and run `nix flake update` again. Alternatively, if gosearch's repository has been updated with the correct hash, this step will work immediately.
- [ ] **Step 3: Commit**
```bash
@ -353,8 +355,11 @@ Expected: HTTP 200 OK response via nginx
- [ ] **Step 8: Test search functionality**
Run: `curl "https://search2.ashisgreat.xyz/search?q=test&format=json"`
Expected: JSON response with search results
Run: `curl -s "https://search2.ashisgreat.xyz/search?q=nixos&format=json" | jq -e '.results | length > 0'`
Expected: Output is `true` (indicating search returned non-empty results)
**Alternative (without jq):** Run: `curl -s "https://search2.ashisgreat.xyz/search?q=nixos&format=json" | grep -o '"results":\s*\[' | wc -l`
Expected: Output is `1` or more (results array is present)
- [ ] **Step 9: Check kafka logs for Valkey connection**