security: harden against SAST findings (criticals through mediums)
Critical: - Validate baseURL/sourceURL/upstreamURL at config load time (prevents XML injection, XSS, SSRF via config/env manipulation) - Use xml.Escape for OpenSearch XML template interpolation High: - Add security headers middleware (CSP, X-Frame-Options, HSTS, etc.) - Sanitize result URLs to reject javascript:/data: schemes - Sanitize infobox img_src against dangerous URL schemes - Default CORS to deny-all (was wildcard *) Medium: - Rate limiter: X-Forwarded-For only trusted from configured proxies - Validate engine names against known registry allowlist - Add 1024-char max query length - Sanitize upstream error messages (strip raw response bodies) - Upstream client validates URL scheme (http/https only) Test updates: - Update extractIP tests for new trusted proxy behavior
This commit is contained in:
parent
4b0cde91ed
commit
da367a1bfd
23 changed files with 399 additions and 41 deletions
|
|
@ -42,7 +42,8 @@ type CORSConfig struct {
|
|||
func CORS(cfg CORSConfig) func(http.Handler) http.Handler {
|
||||
origins := cfg.AllowedOrigins
|
||||
if len(origins) == 0 {
|
||||
origins = []string{"*"}
|
||||
// Default: no CORS headers. Explicitly configure origins to enable.
|
||||
origins = nil
|
||||
}
|
||||
|
||||
methods := cfg.AllowedMethods
|
||||
|
|
@ -70,6 +71,7 @@ func CORS(cfg CORSConfig) func(http.Handler) http.Handler {
|
|||
origin := r.Header.Get("Origin")
|
||||
|
||||
// Determine the allowed origin for this request.
|
||||
// If no origins are configured, CORS is disabled entirely — no headers are set.
|
||||
allowedOrigin := ""
|
||||
for _, o := range origins {
|
||||
if o == "*" {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue